Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check game modes for mode-specific hud panels #139

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Conversation

PeenScreeker
Copy link
Member

@PeenScreeker PeenScreeker commented Aug 8, 2024

This pull request prevents some gamemode-specific hud elements from processing data outside of their intended modes

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@PeenScreeker PeenScreeker self-assigned this Aug 8, 2024
scripts/hud/df-jump.js Outdated Show resolved Hide resolved
@PeenScreeker PeenScreeker force-pushed the feat/gamemode-check branch 2 times, most recently from 0b67a5b to ab2b889 Compare August 20, 2024 02:53
@tsa96 tsa96 merged commit 074140d into master Aug 20, 2024
1 check passed
@tsa96 tsa96 deleted the feat/gamemode-check branch August 20, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants